Skip to content

UNDERTOW-1794 DefaultAccessLogReceiver violates Closeable contract #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.2.x
Choose a base branch
from
Open

UNDERTOW-1794 DefaultAccessLogReceiver violates Closeable contract #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab5515
[UNDERTOW-1794] improve DefaultAccessLogReceiver to obey contract!
baranowb Oct 6, 2020
ace463d
[UNDERTOW-1794] Add properties to allow set retry count/delay
baranowb May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion core/src/main/java/io/undertow/UndertowLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,4 +474,20 @@ void nodeConfigCreated(URI connectionURI, String balancer, String domain, String
@LogMessage(level = WARN)
@Message(id = 5106, value = "Content mismatch for '%s'. Expected length '%s', but was '%s'.")
void contentEntryMismatch(Object key, long indicatedSize, long written);
}

@LogMessage(level = DEBUG)
@Message(id = 5107, value = "Access Log Worker failed to transition gracefuly.")
void accessLogWorkerFailureOnTransition();

@LogMessage(level = DEBUG)
@Message(id = 5108, value = "Access Log Worker failed to reschedule.")
void accessLogWorkerFailureOnReschedule();

@LogMessage(level = DEBUG)
@Message(id = 5109, value = "Access Log Worker did not terminate cleanly.")
void accessLogWorkerNoTermination();

@LogMessage(level = DEBUG)
@Message(id = 5110, value = "Interruption in close()")
void closeInterrupted(@Cause InterruptedException ie);
}
4 changes: 4 additions & 0 deletions core/src/main/java/io/undertow/UndertowMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,8 @@ public interface UndertowMessages {

@Message(id = 207, value = "Invalid SNI hostname '%s'")
IllegalArgumentException invalidSniHostname(String hostNameValue, @Cause Throwable t);

@Message(id = 209, value = "Failed to schedule access message. Access logger is closing.")
IllegalStateException failedToLogAccessOnClose();

}
Loading