Skip to content

[UNDERTOW-2588] avoid buffer clear that breaks NewSessionTicket writes #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[UNDERTOW-2588] avoid buffer clear that breaks NewSessionTicket writes #1771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
165af62
[UNDERTOW-2588] avoid buffer clear that breaks NewSessionTicket writes
aogburn Jul 28, 2025
58f2f35
[UNDERTOW-25898] add clarifying comments
aogburn Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/java/io/undertow/server/protocol/http/HttpResponseConduit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ private int processWrite(int state, final Object userData, int pos, int length)
if (done || exchange == null) {
throw new ClosedChannelException();
}
boolean buffDone = true;
ByteBuffer buffer = null;
try {
assert state != STATE_BODY;
Expand Down Expand Up @@ -157,6 +158,8 @@ private int processWrite(int state, final Object userData, int pos, int length)
res = next.write(data, 0, length + 1);
}
if (res == 0) {
// UNDERTOW-2588 - skip bufferDone() for a STATE_BUF_FLUSH return
buffDone = false;
return STATE_BUF_FLUSH;
}
} while (buffer.hasRemaining());
Expand Down Expand Up @@ -291,12 +294,15 @@ private int processWrite(int state, final Object userData, int pos, int length)
res = next.write(data, 0, index + length);
}
if (res == 0) {
// UNDERTOW-2588 - skip bufferDone() for a STATE_BUF_FLUSH return
buffDone = false;
return STATE_BUF_FLUSH;
}
} while (buffer != null && buffer.hasRemaining());
return STATE_BODY;
} finally {
if (buffer != null) {
if (buffer != null && buffDone) {
// UNDERTOW-2588 - skip this for a STATE_BUF_FLUSH return
bufferDone();
this.state &= ~POOLED_BUFFER_IN_USE;
}
Expand Down
Loading