Skip to content

Explain: Improve phrasing around the last-value tool's output. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark-undoio merged 1 commit into from
Oct 31, 2025
Merged

Explain: Improve phrasing around the last-value tool's output. #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions explain/explain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ def _call_handler(_):

message = result_forwards.output

if m := re.search(r".*Now =.*", message):
if m := re.search(r".*Now = (.*)", message):
# If we found a value change, extract just the "Now =" part of the message.
message = m[0]
message = f"has just been assigned value {m[1]}"

# Put short messages on the same line as "Expression changed".
separator = " " if len(message.splitlines()) == 1 else "\n"
Expand Down
4 changes: 0 additions & 4 deletions explain/instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ source lines:
This works even when the memory location was modified a long time ago or in a
different function.

When `last` returns it specifies a "Was" value, which is what you were
investigating. "Now" is the previous value, which should be ignored or used
for a new debugging hypothesis.

`last` will only work for values that are currently in scope. If a value is not
currently in scope then you need to navigate backwards in time until it is. Using
`reverse_step`, `reverse_next` and `reverse_finish` can help you work
Expand Down