Explain: Fix passthrough of environment to Copilot CLI.#93
Merged
mark-undoio merged 1 commit intomasterfrom Nov 6, 2025
Merged
Explain: Fix passthrough of environment to Copilot CLI.#93mark-undoio merged 1 commit intomasterfrom
mark-undoio merged 1 commit intomasterfrom
Conversation
This bug caused errors of the form: ``` env: 'node': No such file or directory ``` To appear when Node was installed at a non-distro path (i.e. installed manually or using NVM, rather than at `/usr/bin/node` by the distro's package manager). This occurred because the `#!/usr/bin/env node` at the start of Copilot's `index.js` couldn't guess a PATH to node. With a distro-based install, env will sometimes guess standard paths for you. This was always a bug in my code but didn't manifest until we saw the right host environment.
barisione
approved these changes
Nov 6, 2025
|
|
||
| allowed_tools = ["UDB_Server", "shell(grep)", "shell(find)", "shell(cat)", "shell(xargs)"] | ||
| env = { | ||
| env_changes = { |
Collaborator
There was a problem hiding this comment.
I think the more idiomatic way of doing this is:
env = {
**os.environ,
"...": ...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug caused errors of the form:
To appear when Node was installed at a non-distro path (i.e. installed manually or using NVM, rather than at
/usr/bin/nodeby the distro's package manager).This occurred because the
#!/usr/bin/env nodeat the start of Copilot'sindex.jscouldn't guess a PATH to node. With a distro-based install, env will sometimes guess standard paths for you.This was always a bug in my code but didn't manifest until we saw the right host environment.