Explain additional Copilot CLI fixes#94
Merged
mark-undoio merged 2 commits intomasterfrom Nov 10, 2025
Merged
Conversation
Building the env dictionary is more Pythonic and also fixes a bug (in which `env=None` was mistakenly passed through due to how `update()` works - bah). I should have done this change as suggested, first time around!
The upstream Copilot project has added support for explicitly specifying additional MCP configuration files (see github/copilot-cli#51). This changeset tidies up our Copilot integration further by using it. As a result, existing MCP configuration should also be retained when running under `explain`.
barisione
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix my unfortunately-broken attempt at a fix from last week, plus incorporate additional tidy-ups made possible by upstream Copilot CLI changes.