Add side effects to package.json#20
Merged
WebReflection merged 1 commit intoungap:mainfrom Dec 6, 2024
Merged
Conversation
Member
|
I am not sure about this one ... I don't mind adding that extra flags but the underlying issue seems to be bundlers incapable of tree-shaking? 🤔 Or better: what scenario are we trying to solve in here? |
Contributor
Author
|
Package allready has |
Member
|
@denisx again, that's what my bundler of choice (rollup) does already for me ... what is this change trying to solve? which bundler is incapable of proper tree-shaking and requires this change? 🤔 |
Contributor
Author
|
yes, more better treeshake. https://rollupjs.org/configuration-options/#treeshake-modulesideeffects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add side effects to package.json to help bundlers cut unused code. Good with named imports.