Conversation
WalkthroughThis update consists of version bumps for several dependencies in various Changes
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
packages/core/template/UI/uni/package.json(1 hunks)packages/core/template/UI/wot/package.json(1 hunks)packages/core/template/base/package.json(1 hunks)packages/core/template/config/lint/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: stable - aarch64-apple-darwin - node@20
- GitHub Check: stable - x86_64-apple-darwin - node@20
- GitHub Check: build (20.x, macos-latest)
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: build (18.x, windows-latest)
- GitHub Check: build (20.x, windows-latest)
🔇 Additional comments (4)
packages/core/template/UI/wot/package.json (1)
3-3: Verifywot-design-univ1.10.0 does not introduce template-breaking changesMinor bumps inside the same major range are usually safe, yet
wot-design-unioccasionally removes/renames components between minors. Please skim the 1.10.0 release notes and make sure:
- No component names/props used by the starter templates were touched.
- Peer-dependency ranges (Vue/UniApp) remain satisfied.
If everything lines up, ship it.
packages/core/template/base/package.json (1)
64-64: Confirm@dcloudio/types3.4.15 stays in sync with the pinned 3.0.0 runtime packagesThe templates lock all runtime packages to the unusual build tag
3.0.0-4060620…, while the type stubs now float at 3.4.x. That usually works, but breaking structural changes in the.d.tsfiles may mis-match the generated code.Quick manual
vue-tsc --noEmiton a freshly generated project is enough to catch it.packages/core/template/UI/uni/package.json (1)
3-3: LGTM – safe patch bump for@dcloudio/uni-uiNo red flags; minor version bump only.
packages/core/template/config/typescript/package.json (1)
6-6: Minor@types/nodebump—double-check Node engine range
@types/node24.0.7 targets Node ≈ 20/22 features. If the generated project advertises compatibility with older LTS releases (≤18), the newer typings may expose unavailable APIs in IntelliSense.Please make sure the
engines.nodefield (if any) aligns.
| "devDependencies": { | ||
| "@uni-helper/eslint-config": "^0.4.0", | ||
| "eslint": "^9.29.0" | ||
| "eslint": "^9.30.0" |
There was a problem hiding this comment.
ESLint 9 is ESM-only and still early—expect plugin breakage
Jumping from 8 → 9 is a breaking change:
• Requires Node ≥ 18
• Many community plugins/configs (including @uni-helper/eslint-config) haven’t published ESLint-9 compatible versions yet.
• ESLint 9 beta tags were released very recently.
Unless the templates have been tested end-to-end with ESLint 9, consider holding at ^8.56.0 for now.
- "eslint": "^9.30.0"
+ "eslint": "^8.56.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "eslint": "^9.30.0" | |
| "eslint": "^8.56.0" |
🤖 Prompt for AI Agents
In packages/core/template/config/lint/package.json at line 8, the ESLint version
is set to "^9.30.0", which is an ESM-only major update requiring Node ≥ 18 and
may cause plugin compatibility issues. To fix this, downgrade the ESLint version
to "^8.56.0" to maintain compatibility and stability until ESLint 9 and related
plugins are fully supported and tested.
1 participant
Update dependencies
Summary by CodeRabbit