Conversation
b0ab457 to
2278eb5
Compare
📝 WalkthroughWalkthroughThree package.json files in the template configuration directory were updated with dependency version bumps: uview-pro from ^0.5.5 to ^0.5.7, ESLint from ^9.39.2 to ^10.0.0, and Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/core/template/config/lint/package.json`:
- Around line 7-8: The package.json currently pins "eslint" to "^10.0.0" which
is incompatible with the configured "@uni-helper/eslint-config" (and its
transitive "@antfu/eslint-config") that require ESLint ^9.10.0; update the
"eslint" dependency value to "^9.10.0" (i.e., change the "eslint" entry in
package.json) to match the peer dependency requirements of
"@uni-helper/eslint-config" so installs and linting succeed until upstream
config supports ESLint 10.
| "@uni-helper/eslint-config": "^0.6.1", | ||
| "eslint": "^9.39.2" | ||
| "eslint": "^10.0.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the latest version and peer dependencies of `@uni-helper/eslint-config`
echo "=== `@uni-helper/eslint-config` latest version info ==="
npm view `@uni-helper/eslint-config` versions --json 2>/dev/null | tail -10
echo ""
echo "=== `@uni-helper/eslint-config`@latest peer dependencies ==="
npm view `@uni-helper/eslint-config`@latest peerDependencies --json 2>/dev/null
echo ""
echo "=== `@antfu/eslint-config`@latest peer dependencies ==="
npm view `@antfu/eslint-config`@latest peerDependencies --json 2>/dev/null
echo ""
echo "=== Check specific version 0.6.1 ==="
npm view `@uni-helper/eslint-config`@0.6.1 peerDependencies --json 2>/dev/nullRepository: uni-helper/create-uni
Length of output: 1171
ESLint 10 is incompatible with the current eslint-config versions.
@uni-helper/eslint-config@0.6.1 and its transitive dependency @antfu/eslint-config both require eslint@^9.10.0 and do not yet support ESLint 10. Attempting to use ESLint ^10.0.0 with @uni-helper/eslint-config@^0.6.1 will cause peer dependency violations and linting failures.
Either:
- Downgrade ESLint to
^9.10.0until@uni-helper/eslint-configreleases a version supporting ESLint 10, or - Wait for
@uni-helper/eslint-configto be updated for ESLint 10 compatibility before bumping ESLint.
🤖 Prompt for AI Agents
In `@packages/core/template/config/lint/package.json` around lines 7 - 8, The
package.json currently pins "eslint" to "^10.0.0" which is incompatible with the
configured "@uni-helper/eslint-config" (and its transitive
"@antfu/eslint-config") that require ESLint ^9.10.0; update the "eslint"
dependency value to "^9.10.0" (i.e., change the "eslint" entry in package.json)
to match the peer dependency requirements of "@uni-helper/eslint-config" so
installs and linting succeed until upstream config supports ESLint 10.
Update dependencies
Summary by CodeRabbit