Feature/create task to sync health entity data #179
Conversation
sachin-mehta
left a comment
sachin-mehta
left a comment
There was a problem hiding this comment.
@Ankit-lab809 I have added my comments.
There was a problem hiding this comment.
Suggestion: add a simple validation check (either at startup or task execution) to fail fast with a clear error message if required config values are missing. @Ankit-lab809
There was a problem hiding this comment.
@Ankit-lab809, consider breaking this big function into smaller helper functions to improve readability and unit testability.
There was a problem hiding this comment.
@Ankit-lab809 I think we should make these hardcoded values, like soft_limit, limit, batch_size etc. as constants/configurable because same hardcoded values must be present in School logic as well. So, in future, if something needs to be changed, we can change in one place only.
No description provided.