Skip to content

CLDR-16292 Update supplemental/ordinals.xml for Spanish ordinal numbers of ~1 and ~3 #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+10 −1
Closed

CLDR-16292 Update supplemental/ordinals.xml for Spanish ordinal numbers of ~1 and ~3 #2769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7987073
CLDR-16292: Spanish ordinals rule for ~1 and ~3
gosplit Mar 9, 2023
fdd219c
CLDR-16292: Spanish ordinals rule for ~1 and ~3, except for 11
gosplit Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/supplemental/ordinals.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ CLDR data files are interpreted according to the LDML specification (http://unic

<!-- 1: other -->

<pluralRules locales="af am an ar ast bg bs ce cs da de dsb el es et eu fa fi fy gl gsw he hr hsb ia id in is iw ja km kn ko ky lt lv ml mn my nb nl no pa pl prg ps pt root ru sd sh si sk sl sr sw ta te th tpi tr ur uz yue zh zu">
<pluralRules locales="af am an ar ast bg bs ce cs da de dsb el et eu fa fi fy gl gsw he hr hsb ia id in is iw ja km kn ko ky lt lv ml mn my nb nl no pa pl prg ps pt root ru sd sh si sk sl sr sw ta te th tpi tr ur uz yue zh zu">
<pluralRule count="other"> @integer 0~15, 100, 1000, 10000, 100000, 1000000, …</pluralRule>
</pluralRules>

Expand All @@ -35,6 +35,10 @@ CLDR data files are interpreted according to the LDML specification (http://unic
<pluralRule count="one">n = 1..4 @integer 1~4</pluralRule>
<pluralRule count="other"> @integer 0, 5~19, 100, 1000, 10000, 100000, 1000000, …</pluralRule>
</pluralRules>
<pluralRules locales="es">
<pluralRule count="one">n % 10 = 1,3 @integer 1, 3, 11, 13, 21, 23, 31, 33, 41, 43, 51, 53, 101, 103, 1001, 1003, …</pluralRule>
Copy link
Member

@grhoten grhoten May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the and n % 100 != 11 and n % 100 != 13. This rule doesn’t apply to 11 and 13 as can be seen in the Number Format Tester.

It’s worth mentioning that these rules only apply towards the masculine adjective form of ordinals and not the other ordinal forms.

Copy link
Author

@gosplit gosplit Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grhoten, Thanks for the review,

For orindal 13:
I believe the Number Format Tester could be incorrect. You can check the spellout-ordinal-masculine-adjective in the rbnf of es.xml.

<rbnfrule value="13">decimo→→;</rbnfrule>

The masculine adjective ordinal of 13(decimotercero) will become decimotercer. This means it will apply the rule, drop o and becomes 13ᵉʳ

For orindal 11:
Meanwhile, the ordinal of 11 is more complex, it could be undécimo,decimoprimero or onceno depends on users in different countries or regions. Reference: undécimo y decimoprimero, formas válidas

The rule only applies to decimoprimero, but not to the others. While the rbnf of es.xml prefers to undécimo, I am keeping 11 unchanged and adding the rule on 13 in rnbf and ordinals.xml

Please help to review again.

<pluralRule count="other"> @integer 0, 2, 4~10, 100, 1000, 10000, 100000, 1000000, …</pluralRule>
</pluralRules>

<!-- 2: few,other -->

Expand Down