CLDR-17014 Move more extra-path code from CLDRFile to ExtraPaths #4332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-This is only refactoring
-This is only refactoring
Member
Author
|
I had checked "This PR completes the ticket", but have now unchecked it based on discussion in the ticket, since we are considering whether TERRITORY, VARIANT, CURRENCY, and CURRENCY_SYMBOL should get the same treatment as LANGUAGE and SCRIPT -- move them from XMLSource::ResolvingSource::constructedItems into ExtraPaths and have their codes not show up as values |
srl295
approved these changes
Feb 3, 2025
Comment on lines
+30
to
+36
| "//ldml/dates/timeZoneNames/zone[@type=\"Pacific/Honolulu\"]/short/generic", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Pacific/Honolulu\"]/short/standard", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Pacific/Honolulu\"]/short/daylight", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Europe/Dublin\"]/long/daylight", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Europe/London\"]/long/daylight", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Etc/UTC\"]/long/standard", | ||
| "//ldml/dates/timeZoneNames/zone[@type=\"Etc/UTC\"]/short/standard", |
Member
There was a problem hiding this comment.
Why are these static? seems extremely fragile.
I know this isn't new and it's from refactoring, but how/why did we end up with a static list in the first place?
Member
There was a problem hiding this comment.
These were items that the TC agreed to add.
macchiati
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-This is only refactoring
CLDR-17014
ALLOW_MANY_COMMITS=true