CLDR-17953 Enable TC to generate VXML #4334
Conversation
-Previously only Admin could use the Generate VXML option in the ☰ menu -New Java function canGenerateVxml, new http response item userCanGenerateVxml to encapsulate this rule on the back end -Rename Java function isTC to isTCOrStronger, for clarity, likewise for isVetter, etc. -Remove some superfluous conditions like userIsAdmin in (userIsAdmin || userIsTCOrStronger) -Do not exhaustively rename ...OrStronger; in particular front end and http response json still have userIsTC, etc.; renaming for front end and json will require caution and is beyond scope of this PR -Refactor a few lines of js for consistency and to ensure boolean: Boolean(perm?.userIsLocked) instead of (perm && perm.userIsLocked) -Comments
| <template> | ||
| <div v-if="!hasPermission">Please log in as Admin to use this feature.</div> | ||
| <div v-if="!hasPermission"> | ||
| Please log in as a user with sufficient permissions. |
There was a problem hiding this comment.
this will practically never happen, since the menu doesn't present the option if the user lacks permission
it could happen if the user saved a bookmark for this page, and then forgot to log in
| } | ||
|
|
||
| public boolean canGenerateVxml() { | ||
| return userIsTCOrStronger(this); |
There was a problem hiding this comment.
this is the only place the rule is determined
| .put("userIsTC", userIsTCOrStronger(this)) | ||
| // Caution: userIsVetter really means user is Vetter or Manager, but not TC or | ||
| // Admin. It should be renamed to avoid confusion. | ||
| .put("userIsVetter", userIsVetterOrStronger(this) && !userIsTCOrStronger(this)) |
There was a problem hiding this comment.
tech debt; I only added a comment for now
There was a problem hiding this comment.
didn't you already rename it? so the comment is out of date?
There was a problem hiding this comment.
No, I renamed the method to userIsVetterOrStronger, but the json item is still userIsVetter
The json item needs a name like userIsVetterOrStrongerButNotTCOrStronger or userIsExactlyVetterOrManager -- such a change is beyond the scope of this ticket though
|
|
||
| // Admin and TC users can always modify, even in closed state. | ||
| if (userIsAdmin(u) || userIsTC(u)) return null; | ||
| if (userIsTCOrStronger(u)) return null; |
There was a problem hiding this comment.
Department of Redundancy Department
| if (!UserRegistry.userIsManagerOrStronger(session.user) | ||
| || (!ORGS_MINE.equals(request.orgs) | ||
| && !UserRegistry.userIsTC(session.user))) { // userIsTC means TC or stronger | ||
| && !UserRegistry.userIsTCOrStronger(session.user))) { |
There was a problem hiding this comment.
One can only add a comment like this so many times before the need to rename the function becomes irresistible
| } | ||
|
|
||
| // The following methods were moved here from UserRegistry | ||
| // TODO: remove this todo notice |
There was a problem hiding this comment.
It should have been a review comment. Apologies.
There was a problem hiding this comment.
no problem! It was just puzzling and funny
| // Caution: userIsVetter really means user is Vetter or Manager, but not TC or | ||
| // Admin. It should be renamed to avoid confusion. |
There was a problem hiding this comment.
| // Caution: userIsVetter really means user is Vetter or Manager, but not TC or | |
| // Admin. It should be renamed to avoid confusion. |
There was a problem hiding this comment.
I think the comment should stay until the json item is renamed or otherwise refactored
2 participants
-Previously only Admin could use the Generate VXML option in the ☰ menu
-New Java function canGenerateVxml, new http response item userCanGenerateVxml to encapsulate this rule on the back end
-Rename Java function isTC to isTCOrStronger, for clarity, likewise for isVetter, etc.
-Remove some superfluous conditions like userIsAdmin in (userIsAdmin || userIsTCOrStronger)
-Do not exhaustively rename ...OrStronger; in particular front end and http response json still have userIsTC, etc.; renaming for front end and json will require caution and is beyond scope of this PR
-Refactor a few lines of js for consistency and to ensure boolean: Boolean(perm?.userIsLocked) instead of (perm && perm.userIsLocked)
-Comments
CLDR-17953
ALLOW_MANY_COMMITS=true