CLDR-18277 json: update PACKAGES.md #4338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- subdivisions should be tiered for consistency (and if we subset it someday) - transforms is NOT tiered - calculate tier from output directory, where possible - also cleanup PACKAGES.md
srl295
requested review from
AEApple,
DraganBesevic,
btangmu,
conradarcturus,
macchiati and
sffc
srl295
requested review from
robertbastian and
sffc
and removed request for
sffc
btangmu
reviewed
Feb 11, 2025
| bcp47(false, false), | ||
| transforms(false, false), | ||
| subdivisions(false, true); | ||
| subdivisions(true, true); |
btangmu
approved these changes
Feb 11, 2025
| } | ||
|
|
||
| // if not tiered | ||
| if (!tiered) { |
Member
There was a problem hiding this comment.
ideally there should be a subroutine isTiered to encapsulate this, and it would return false as soon as it saw "core". The surrounding method writePackageList is too long, over 100 lines; it's writing two files at once, cldr-packages.json and PACKAGES.md. It would be helpful -- make changes easier to review -- if it were organized into subroutines
Member
Author
There was a problem hiding this comment.
yes and part of the challenge is that it's not looking at RunType at that point but output directories. But agree on subroutines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18277
ALLOW_MANY_COMMITS=true