CLDR-18240 Check for null baileyValue in VoteResolver #4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-In resolveVotes, do not return INHERITANCE_MARKER if baileyValue is null -Do not misinterpret the boolean baileySet as implying baileyValue is not null -Always call getBaileyValue instead of reading baileyValue directly, to enforce the requirement that setBaileyValue must be called before getBaileyValue -Make VoteResolver.getBaileyValue private; it was not called by other classes -Comments; clarify that baileySet may be true even if baileyValue is false; it only indicates that setBaileyValue was called
btangmu
commented
Feb 5, 2025
| winningValue, winningStatus); | ||
| // Declare the winner here, because we're about to return from the function | ||
| } else if (organizationToValueAndVote.baileySet) { | ||
| } else if (getBaileyValue() != null) { |
Member
Author
There was a problem hiding this comment.
this is the essential bug fix
macchiati
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-In resolveVotes, do not return INHERITANCE_MARKER if baileyValue is null
-Do not misinterpret the boolean baileySet as implying baileyValue is not null
-Always call getBaileyValue instead of reading baileyValue directly, to enforce the requirement that setBaileyValue must be called before getBaileyValue
-Make VoteResolver.getBaileyValue private; it was not called by other classes
-Comments; clarify that baileySet may be true even if baileyValue is false; it only indicates that setBaileyValue was called
CLDR-18240
ALLOW_MANY_COMMITS=true