Skip to content

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 21, 2025

CLDR-18369

The Temporal ECMAScript Intl Era Month Code proposal has reached Stage 2.7 (like "final draft") with these era codes. I would like to align CLDR's era codes with ECMA's era codes so that we avoid having two sets in the ecosystem.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@sffc sffc changed the title Revise era codes based on March 20 discussion CLDR-18369 Revise era codes based on March 20 discussion Mar 21, 2025
Comment on lines 4838 to 4839
<era type="0" end="284-08-28" code="??? TODO ???"/>
<era type="1" start="284-08-29" code="am" primary="true"/> <!-- Anno Martyrum -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a suggestion at tc39/proposal-intl-era-monthcode#25 (comment):

the Coptic calendar should have eras BD and AD, not BM and AM

However, it's at least partly at odds with other resources I can find, all of which use "AM" or "A.M.":

I do see references to A.D. (from "anno Diocletiani"), but concrete usage seems rare. I have no opinion on which is more correct here.

@sffc
Copy link
Member Author

sffc commented Mar 29, 2025

@macchiati any comments on this before you disappear on vacation? (I see you already left one regarding ID stability)

@sffc
Copy link
Member Author

sffc commented Jun 27, 2025

I recall @macchiati stating that he was concerned about removing the CLDR 43 codes from the file and preferred them as aliases, though the CLDR Design WG seemed okay with that path on 2025-03-31:

Shane: Is it a hard requirement to retain the old codes (added in CLDR 43, CLDR-16417), or can we just discard them? No evidence of usage.

Rich: If Temporal is the only user, and they want to change it, I'm fine changing it

Markus: If the person proposing this change wants to change it, and they're not aware of other users, it seems fine to change it

I don't have any written documentation of Mark's position and whether it is required for landing this PR or otherwise changes the Design WG opinion. Could you clarify?

@sffc sffc changed the title CLDR-18369 Revise era codes based on March 20 discussion CLDR-18369 Revise era codes to match Temporal specification Aug 4, 2025
@sffc sffc marked this pull request as ready for review August 4, 2025 23:29
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member Author

sffc commented Aug 6, 2025

CLDR-TC approved this with the following notes in https://unicode-org.atlassian.net/browse/CLDR-18369

  • Temporal was the original requester for the string era names, so we decided to align with Temporal (we don’t know of any adoption beyond ICU4X)
  • Need a note in the migration section of the CLDR 48 release notes

I need to write a migration note for both this and #4620. I intend to merge this PR to update the data and unblock integrations, but the ticket should not be closed until the migration guide is updated (which I plan to do in a separate PR).

@sffc
Copy link
Member Author

sffc commented Aug 9, 2025

The CLDR-TC approved this PR for alignment with Temporal, so I am going to finally hit the merge button.

@sffc sffc merged commit 0e8f575 into unicode-org:main Aug 9, 2025
11 checks passed
@sffc sffc deleted the new-era-codes branch August 9, 2025 01:08
@@ -4304,8 +4304,8 @@ XXX Code for transations where no currency is involved
<calendar type="gregorian">
<calendarSystem type="solar" />
<eras>
<era type="0" end="0-12-31" code="gregory-inverse" aliases="bc bce"/>
<era type="1" start="1-01-01" code="gregory" aliases="ad ce"/>
<era type="0" end="0-12-31" code="bce" aliases="bc"/> <!-- Before Common Era, Before Christ -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sffc why is type: 0 used for the backwards-counting, earlier era here, but is used for the forwards-counting, later era in most (all?) calendars below? Are 0 vs. 1 meaningful in any way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are generally chronological with the exception of AH/BH, which had a whole discussion in #4581

@sffc sffc mentioned this pull request Aug 11, 2025
1 task
@sffc
Copy link
Member Author

sffc commented Aug 11, 2025

Release notes in #4952

@bmkkakabmkkaka0-commits
Copy link

@macchiati any comments on this before you disappear on vacation? (I see you already left one regarding ID stability)

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants