CLDR-18369 Update era names #5048

robertbastian · 2025-09-16T10:21:06Z

This PR completes the ticket.

Now that we've aligned all the codes with the correct abbreviations, we should also align the names in root. This finally gets rid of ERA0 and ERA1 for Ethiopic.

The Coptic era was already updated in #4620, that should have probably been a separate PR.

ALLOW_MANY_COMMITS=true

jira-pull-request-webhook · 2025-09-16T10:56:46Z

Notice: the branch changed across the force-push!

common/main/root.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2025-09-16T11:26:00Z

Notice: the branch changed across the force-push!

common/main/root.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2025-09-16T11:38:49Z

Notice: the branch changed across the force-push!

common/main/root.xml is different
common/main/sat.xml is now changed in the branch
common/main/ta.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

common/main/root.xml

common/main/en.xml

macchiati · 2025-09-16T18:31:10Z

common/main/root.xml

 				</dayPeriods>
 				<eras>
 					<eraNames>
-						<alias source="locale" path="../eraAbbr"/>


Cannot add or remove aliases without TC approval. Affects all of inheritance.

jira-pull-request-webhook · 2025-09-16T20:01:20Z

Notice: the branch changed across the force-push!

common/main/en.xml is no longer changed in the branch
common/main/es_419.xml is no longer changed in the branch
common/main/fi.xml is no longer changed in the branch
common/main/fr_CA.xml is no longer changed in the branch
common/main/fr.xml is different
common/main/is.xml is no longer changed in the branch
common/main/ro.xml is no longer changed in the branch
common/main/root.xml is different
common/main/sat.xml is no longer changed in the branch
common/main/ta.xml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc

LGTM, thanks for making the change more narrow!

AEApple

We are past data freeze. This will need approval from both the CLDR and ICU TCs at this point in the release or you can wait until CLDR 49.

robertbastian · 2025-09-16T20:59:28Z

So the first CLDR-JSON we could use to test with ICU4X was released after the data freeze, so now I have to go begging to two TCs for any issue we find?

AEApple · 2025-09-16T21:04:16Z

So the first CLDR-JSON we could use to test with ICU4X was released after the data freeze, so now I have to go begging to two TCs for any issue we find?

I think this means that we need to refine the schedule to consider ICU4X. Historically ICU4X's release timelines were not aligned with the CLDR or ICU timelines but were independent.

robertbastian · 2025-09-16T21:11:08Z

Historically ICU4X's release timelines were not aligned with the CLDR or ICU timelines but were independent.

ICU4X has tested every CLDR release since I've been on the project as soon as a CLDR-JSON was available. This has always been way later than ICU could start integration, which I point out every time, but I don't think it has ever been after data freeze.

AEApple · 2025-09-16T21:45:09Z

Historically ICU4X's release timelines were not aligned with the CLDR or ICU timelines but were independent.

ICU4X has tested every CLDR release since I've been on the project as soon as a CLDR-JSON was available. This has always been way later than ICU could start integration, which I point out every time, but I don't think it has ever been after data freeze.

It has always been after data freeze at least according to the CLDR BRS. In general we only start generating CLDR JSON data after alpha2 and sometimes after public alpha but always before public beta.

It may have been happening but since it isn't currently reflected that way in the BRS checklist, we should make sure that is updated so that you can test earlier. Otherwise it's likely to get missed if we are running late for any reason.

macchiati · 2025-09-16T23:30:00Z

Moved to draft to avoid getting inadvertently merged before we settle remaining issues.

AEApple · 2025-09-17T16:01:40Z

Saka change was discussed in https://unicode-org.atlassian.net/browse/CLDR-18487

macchiati · 2025-09-17T22:00:44Z

common/main/root.xml

 					</eraNames>
 					<eraAbbr>
-						<era type="0">ERA0</era>
+						<alias source="locale" path="../../../calendar[@type='ethiopic']/eras/eraAbbr/era[@type='0']"/>


I looked this over, and I think it is ok if we change to:

Suggested change

<alias source="locale" path="../../../calendar[@type='ethiopic']/eras/eraAbbr/era[@type='0']"/>

<alias source="locale" path="../../../calendar[@type='ethiopic']/eras/eraAbbr"/>

The aliases take the asked-for path, plus the location of the alias itself, in order to construct the new path. You can see that in the other cases. That being said, I haven't tested this out.

We don't want to pull in both eras, just the one with type=0

That's not the way that they work: https://unicode.org/reports/tr35/tr35.html#Alias_Elements
That would map any missing item (eg type='1') to the 0 value.

However, I see that you've removed this, so it's moot.

I removed it from this PR so it can get merged, but we need to figure out some mechanism to keep these era names in sync.

We might be able to just remove translations for ethipic-amete-alem altogether if patterns also match ethiopic.

Agreed, we do that for the Islamic variants!

jira-pull-request-webhook · 2025-09-26T08:50:46Z

Notice: the branch changed across the force-push!

common/main/root.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2025-09-26T11:12:20Z

Notice: the branch changed across the force-push!

common/main/bn.xml is now changed in the branch
common/main/da.xml is now changed in the branch
common/main/ff_Adlm.xml is now changed in the branch
common/main/gu.xml is now changed in the branch
common/main/he.xml is now changed in the branch
common/main/is.xml is now changed in the branch
common/main/mk.xml is now changed in the branch
common/main/ml.xml is now changed in the branch
common/main/mr.xml is now changed in the branch
common/main/nl.xml is now changed in the branch
common/main/no.xml is now changed in the branch
common/main/pa.xml is now changed in the branch
common/main/shn.xml is now changed in the branch
common/main/ur.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati

You're now removing all the values, even those that change script. I understand that they are probably incorrect in that they include "0", but the Latin abbreviation is probably no better. However, to get this moving I'm approving.

robertbastian · 2025-09-29T14:16:19Z

ping @AEApple

robertbastian · 2025-09-29T16:42:11Z

autosubmit please

github-actions bot assigned robertbastian Sep 16, 2025

robertbastian force-pushed the eras branch from 83488e0 to 9964dde Compare September 16, 2025 10:56

robertbastian requested a review from sffc September 16, 2025 11:02

robertbastian force-pushed the eras branch from 191c616 to 08e2b1f Compare September 16, 2025 11:25

robertbastian changed the title ~~CLDR-18369 Update root era names~~ CLDR-18369 Update era names Sep 16, 2025

robertbastian force-pushed the eras branch from 08e2b1f to b5f24d9 Compare September 16, 2025 11:38

sffc requested changes Sep 16, 2025

View reviewed changes

common/main/root.xml Outdated Show resolved Hide resolved

common/main/en.xml Show resolved Hide resolved

macchiati requested changes Sep 16, 2025

View reviewed changes

robertbastian force-pushed the eras branch from b5f24d9 to 9f3a99a Compare September 16, 2025 20:01

robertbastian force-pushed the eras branch from 9f3a99a to ab4b4db Compare September 16, 2025 20:04

sffc previously approved these changes Sep 16, 2025

View reviewed changes

sffc requested a review from macchiati September 16, 2025 20:05

AEApple requested changes Sep 16, 2025

View reviewed changes

macchiati marked this pull request as draft September 16, 2025 23:27

macchiati reviewed Sep 17, 2025

View reviewed changes

robertbastian mentioned this pull request Sep 26, 2025

CLDR-18369 Remove "incarnation" translations of Amete eras #5053

Merged

1 task

robertbastian dismissed sffc’s stale review via a47fac5 September 26, 2025 08:50

robertbastian force-pushed the eras branch from ab4b4db to a47fac5 Compare September 26, 2025 08:50

robertbastian requested a review from macchiati September 26, 2025 08:50

robertbastian requested a review from AEApple September 26, 2025 08:50

robertbastian marked this pull request as ready for review September 26, 2025 08:51

robertbastian added 2 commits September 26, 2025 11:36

CLDR-18369 Update root era names

a91fc7f

CLDR-18369 Remove translations of "ERA0"/"ERA1"

7b124f0

robertbastian force-pushed the eras branch from a47fac5 to 7b124f0 Compare September 26, 2025 11:12

macchiati approved these changes Sep 26, 2025

View reviewed changes

This comment was marked as spam.

Sign in to view

macchiati approved these changes Sep 29, 2025

View reviewed changes

AEApple approved these changes Sep 29, 2025

View reviewed changes

robertbastian merged commit 0d02d32 into unicode-org:main Sep 29, 2025
11 checks passed

robertbastian deleted the eras branch September 29, 2025 18:33

	<alias source="locale" path="../../../calendar[@type='ethiopic']/eras/eraAbbr/era[@type='0']"/>
	<alias source="locale" path="../../../calendar[@type='ethiopic']/eras/eraAbbr"/>

CLDR-18369 Update era names #5048

CLDR-18369 Update era names #5048

Uh oh!

Conversation

robertbastian commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jira-pull-request-webhook bot commented Sep 16, 2025

Uh oh!

jira-pull-request-webhook bot commented Sep 16, 2025

Uh oh!

jira-pull-request-webhook bot commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

macchiati Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

jira-pull-request-webhook bot commented Sep 16, 2025

Uh oh!

sffc left a comment

Choose a reason for hiding this comment

Uh oh!

AEApple left a comment

Choose a reason for hiding this comment

Uh oh!

robertbastian commented Sep 16, 2025

Uh oh!

AEApple commented Sep 16, 2025

Uh oh!

robertbastian commented Sep 16, 2025

Uh oh!

AEApple commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macchiati commented Sep 16, 2025

Uh oh!

AEApple commented Sep 17, 2025

Uh oh!

macchiati Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

robertbastian Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

macchiati Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

robertbastian Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

macchiati Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

jira-pull-request-webhook bot commented Sep 26, 2025

Uh oh!

jira-pull-request-webhook bot commented Sep 26, 2025

Uh oh!

macchiati left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

robertbastian commented Sep 29, 2025

Uh oh!

robertbastian commented Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

robertbastian commented Sep 16, 2025 •

edited

Loading

AEApple commented Sep 16, 2025 •

edited

Loading