Skip to content

Conversation

@grhoten
Copy link
Member

@grhoten grhoten commented Oct 26, 2025

CLDR-19089

While these changes don't fully fix parsing with Irish RBNF rules. It's one step closer. I tested these rules with Number Format Tester.

Here are the important changes:

  • The year is now pronounced correctly. It's not supposed to use English style spelling. It uses a more traditional form.
  • The cardinals are now separated from counting numbers.
  • Numbers like 2000 and 2001 are now correctly parsing, but numbers like 212212 still struggle to parse correctly. It's due to Irish's unusual ordering for the tens range to have the tens after the unit. The order is like "two hundred two thousand ten two hundred two ten" for the value 212212.
  • This PR completes the ticket.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@grhoten grhoten changed the title CLDR-19089 Fix parsing of Irish RBNF rules CLDR-19089 Fix parsing of numbers with Irish RBNF rules Oct 26, 2025
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/rbnf/ga.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/rbnf/ga.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/rbnf/ga.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@grhoten grhoten changed the title CLDR-19089 Fix parsing of numbers with Irish RBNF rules CLDR-19089 Improve parsing of numbers with Irish RBNF rules Oct 27, 2025
@grhoten
Copy link
Member Author

grhoten commented Oct 29, 2025

@srl295 @AEApple for review as per the CLDR TC meeting. I can't request a reviewer here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant