CLDR-19098 Refactoring; new ExemplarSets.java #5188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Move sets and ExemplarType from CheckExemplars into new org.unicode.cldr.util.ExemplarSets -Replace CLDRFile.ExemplarType with ExemplarSets.ExemplarType -Related refactoring; move some code into subroutines; change public to private where possible -Some automated refactoring by IntelliJ, from accepting suggestions linked to compiler warnings
1 task
Member
Author
|
Please note: this includes the changes that were in the earlier PR #5185 |
Member
Author
|
@macchiati these changes are based on your suggestions in the first merged PR #5184 |
srl295
previously approved these changes
Nov 11, 2025
| new UnicodeSet( | ||
| "[[[:Nd:][:script=common:][:script=inherited:]-[:Default_Ignorable_Code_Point:]-[:C:] - [_]] [\u05BE \u05F3 \u066A-\u066C]" | ||
| + "[[؉][་ །༌][ཱ]{য়}য়]" | ||
| + // TODO Fix this Hack |
Member
Author
There was a problem hiding this comment.
Comment on lines
24
to
30
| static { | ||
| ExemplarSets.Japn.set(UScript.HAN); | ||
| ExemplarSets.Japn.set(UScript.HIRAGANA); | ||
| ExemplarSets.Japn.set(UScript.KATAKANA); | ||
| ExemplarSets.Kore.set(UScript.HAN); | ||
| ExemplarSets.Kore.set(UScript.HANGUL); | ||
| } |
Member
There was a problem hiding this comment.
Japnis a typo, should beJpan- all of this should be dynamic, using the script data as below:
<scriptData>
<scriptVariant type="compound" id='Hanb' base='Hani Bopo'/> <!-- Han with Bopomofo (alias for Han + Bopomofo) -->
<scriptVariant type="compound" id='Jpan' base='Hani Hira Kana'/> <!-- Japanese (alias for Han + Hiragana + Katakana) -->
<scriptVariant type="compound" id='Hrkt' base='Hira Kana'/> <!-- Japanese syllabaries (alias for Hiragana + Katakana) -->
<scriptVariant type="compound" id='Kore' base='Hang Hani'/> <!-- Korean (alias for Hangul + Han) -->
<scriptVariant type="compound" id='Hntl' base='Hant Latn'/> <!-- Han (Traditional variant) with Latin (alias for Hant + Latn) -->
Member
Author
There was a problem hiding this comment.
Thanks, I'll study this -- do you mean that data exists and the Java code should be based on that data?
Member
There was a problem hiding this comment.
Need ticket for adding API to SupplementalDataInfo for accessing that date, and replacing hardcoded lists here and elsewhere. See CLDR-18950
-TODO comments referencing tickets
Member
Author
|
The 2nd commit changes Japn to Jpan and adds references in TODO comments. |
srl295
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Move sets and ExemplarType from CheckExemplars into new org.unicode.cldr.util.ExemplarSets
-Replace CLDRFile.ExemplarType with ExemplarSets.ExemplarType
-Related refactoring; move some code into subroutines; change public to private where possible
-Some automated refactoring by IntelliJ, from accepting suggestions linked to compiler warnings
-Change Japn to Jpan and add reference tickets for TODO comments
CLDR-19098
ALLOW_MANY_COMMITS=true