-
Notifications
You must be signed in to change notification settings - Fork 419
CLDR-19142 Improve ST warnings for invalid path votes #5214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-Clarify that the warning is in response to a vote -Include the exception cause (PH for path ... Caused by...) -Include the USV (U+...) -Fix message that said minor category (subgroup) but meant major category (group) -Change Probably mismatch to Possible mismatch (in this case it was not the cause)
|
This PR changes the warning from to The cause (No minor category...) and the context (vote) are added, and the cause includes the USV for the emoji (U+1FADD). This info should make such errors easier to diagnose in the future. The question remains, what more should be done, if anything. We could delete the votes from the database. That would de-noise the logs, and prevent bogus votes from harming future data supposing U+1FADD is assigned a completely different emoji. On the other hand, if "apple core" does get added, the data could still be useful. |
|
My suggestion is to remove from main. If we need that date in the future, we can recover the data from the release (or one of the tags) |
The XML data was already removed in #4895 and it could be recovered from git. I'm wondering whether we should remove the votes from the database. I don't have a strong opinion one way or the other. If we don't remove the votes, there will be noise in the logs (not a big problem), and when/if U+1FADD apple core is approved, the votes may get imported and effectively bring back the annotations without needing to recover them from git. However, if U+1FADD gets assigned some other meaning, like "orange peel", then we'll have confusion between "apple core" and "orange peel" unless the votes have been removed... |
|
Excellent catch. Yes, please remove from the database
…On Thu, Dec 4, 2025, 05:54 Tom Bishop ***@***.***> wrote:
*btangmu* left a comment (unicode-org/cldr#5214)
<#5214 (comment)>
remove from main
The XML data was already removed in #4895
<#4895> and it could be recovered
from git.
I'm wondering whether we should remove the votes from the database. I
don't have a strong opinion one way or the other. If we don't remove the
votes, there will be noise in the logs (not a big problem), and when/if
U+1FADD apple core is approved, the votes may get imported and effectively
bring back the annotations without needing to recover the from git.
However, if U+1FADD gets assigned some other meaning, like "orange peel",
then we'll have confusion between "apple core" and "orange peel" unless the
votes have been removed...
—
Reply to this email directly, view it on GitHub
<#5214 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMC2AVHUUXBBR5WUDET4AA4HPAVCNFSM6AAAAACN6K4SH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJSGM3TOMJWGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
OK, I've just done so, on the production server, as follows: |
Concur |
-Clarify that the warning is in response to a vote
-Include the exception cause (PH for path ... Caused by...)
-Include the USV (U+...)
-Fix message that said minor category (subgroup) but meant major category (group)
-Change Probably mismatch to Possible mismatch (in this case it was not the cause)
CLDR-19142
ALLOW_MANY_COMMITS=true