Skip to content

Node errors for locale display names to 'unsupported' #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sven-oly merged 9 commits into from
Jan 6, 2025
Merged

Node errors for locale display names to 'unsupported' #319

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5da5872
Node errors for locale display names to 'unsupported'
Oct 2, 2024
66692b1
Merge branch 'unicode-org:main' into fix_node_langname_errors
sven-oly Oct 8, 2024
ebe3561
Set node locale names errors to unsupported
Oct 8, 2024
569ba77
NodeJS: set unsupported locales for locale display names
Oct 8, 2024
d1e808e
Merge remote-tracking branch 'upstream/main' into fix_node_langname_e…
Nov 5, 2024
5655530
Adding info to error messages
Nov 6, 2024
1514884
Merge remote-tracking branch 'upstream/main' into fix_node_langname_e…
Dec 19, 2024
1a3e4a0
Merge remote-tracking branch 'upstream/main' into fix_node_langname_e…
Dec 19, 2024
75ad03e
Set display language problem to unsupported
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions executors/node/localedisplaynames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ module.exports = {
"error_type": "unsupported",
"error_retry": false // Do not repeat
};
if (error instanceof RangeError) {
// The locale can't be handled for some reason!
outputLine["error_type"] = 'unsupported';
outputLine["unsupported"] = error.toString();
outputLine["error_detail"] = 'unsupported locale';
}
Comment on lines +38 to +68
Copy link
Member

@sffc sffc Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error instanceof RangeError seems a bit broad. I suggest a narrower case for returning unsupported.

Copy link
Collaborator Author

@sven-oly sven-oly Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, there are two types of failures right now. Here's what I see being caught as exceptions:

  1. Unexpected options in the locale spec, e.g., "label":"0009","language_label":"en-u-nu-deva-t-de","locale_label":"en"

--> "RangeError: invalid_argument"

  1. "root" locale --> "RangeError: invalid_argument" in the constructor.

Should either of these be "unsupported"?

Copy link
Collaborator Author

@sven-oly sven-oly Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think classifying these as "unsupported" is correct. This will resolve a large number of "errors" --> "unsupported", i.e.,

Report created: 2024-10-07 10:36

1,990 attempted. Pass: 1,460, Fail: 214, Errors: 316, Unsupported: 0

Copy link
Collaborator Author

@sven-oly sven-oly Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL!

return outputLine;
}

Expand All @@ -45,13 +51,19 @@ module.exports = {
"result": resultString
};
} catch (error) {
const error_string = error.toString();
outputLine = {"label": json['label'],
"locale_label": locale,
"language_label": input,
"result": resultString,
"error": error.toString(),
"actual_options": options.toString()
"error": error_string,
"actual_options": options.toString(),
};
outputLine["error_type"] = 'unsupported';
outputLine["unsupported"] = error_string;
if (error instanceof RangeError) {
// The locale can't be handled for some reason!
outputLine["error_detail"] = 'unsupported locale';
}
}
return outputLine;
}
Expand Down