Node and PluralRules: use supported locales in place of obsolete locales#380
Merged
sven-oly merged 1 commit intounicode-org:mainfrom Jan 8, 2025
Merged
Conversation
sffc
approved these changes
Jan 8, 2025
Comment on lines
48
to
+58
| try { | ||
| const supported_locales = | ||
| Intl.PluralRules.supportedLocalesOf(locale, test_options); | ||
|
|
||
| if (!supported_locales.includes(locale)) { | ||
|
|
||
| return {"label": label, | ||
| "error" : "unusupported", | ||
| "unsupported": "unsupported_locale", | ||
| "error_detail": {'unsupported_locale': locale, | ||
| 'supported_locals': supported_locales, | ||
| 'test_options': test_options | ||
| } | ||
| }; | ||
| if (supported_locales.includes(locale)) { | ||
| actual_locale = locale; | ||
| } else { | ||
| if (supported_locales) { | ||
| actual_locale = supported_locales[0]; | ||
| } | ||
| if (actual_locale == undefined) { | ||
| // No, there's no good substitute. |
Member
There was a problem hiding this comment.
This code is more complex than it needs to be, but I believe it is technically correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#379
Note that this PR changes Node failing tests from 77 to 87, but reduces "unsupported" from 432 to 216, the same as the other platforms.