Skip to content
/ icu Public

ICU-23305 Fix int64_t overflow in doParse #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankYFTang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23305 Fix int64_t overflow in doParse #3831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions icu4c/source/i18n/nfsubs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,10 +1343,18 @@ NumeratorSubstitution::doParse(const UnicodeString& text,
int64_t n = result.getLong(status); // force conversion!
int64_t d = 1;
while (d <= n) {
if (d > U_INT64_MAX / 10) {
// Will cause int64_t overflow
return false;
}
d *= 10;
}
// now add the zeros
while (zeroCount > 0) {
if (d > U_INT64_MAX / 10) {
// Will cause int64_t overflow
return false;
}
d *= 10;
--zeroCount;
}
Expand Down