Skip to content
/ icu Public

ICU-23306 Atomic [:^ #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eggrobin merged 1 commit into from
Jan 9, 2026
Merged

ICU-23306 Atomic [:^ #3838

eggrobin merged 1 commit into from
Jan 9, 2026
+6 −13

Conversation

@eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 9, 2026

https://www.youtube.com/watch?v=O_WLw_0DFQQ

Checklist

  • Required: Issue filed: ICU-23306
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

richgillam
richgillam previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM

@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Jan 9, 2026

Notice: the branch changed across the force-push!

  • icu4c/source/common/uniset_props.cpp is different
  • icu4c/source/test/intltest/usettest.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@eggrobin
Copy link
Member Author

eggrobin commented Jan 9, 2026

(It conflicted with the other one so I will need a new rubberstamp.)

@eggrobin eggrobin requested a review from richgillam January 9, 2026 22:30
richgillam
richgillam approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LOKTM. :-)

@eggrobin eggrobin merged commit a445167 into unicode-org:main Jan 9, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richgillam richgillam richgillam approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eggrobin @richgillam