-
-
Notifications
You must be signed in to change notification settings - Fork 862
ICU-23307 Space-sensitive UnicodeSet string literals #3839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Somehow this is affecting |
|
Latin-NumericPinyin.xml: Whyyy??! |
|
de-ASCII also does this: and blt-fonipa-t-blt: These seem to be the only users of space-insensitivity of string literals. |
|
An artifact, that we just never noticed before the change
…On Fri, Jan 9, 2026, 09:30 Robin Leroy ***@***.***> wrote:
*eggrobin* left a comment (unicode-org/icu#3839)
<#3839 (comment)>
Latin-NumericPinyin.xml:
($tone) ( [i o n u {o n} {n g}]) → $2 &Pinyin-NumericPinyin($1);
Whyyy??!
—
Reply to this email directly, view it on GitHub
<#3839 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMC3UQT5PIQVFD2URAL4F7QVBAVCNFSM6AAAAACRGSRVNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMRZHEYDMMRSGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I added something to the CLDR-design agenda. (Not sure I can make it Monday, I expect this week to be chaotic—I am moving Friday—, but I’m sure you have enough context to discuss this topic.) |
197ff20 to
0b09ebb
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu How do I deal with the transliterator breakages until CLDR fixes its rules? Do I just sit on this PR until then? |
|
We can get them into v49 if we act in the next few days. I'm away from my
computer right now, but can handle that if you have the exact list of
needed changes, the follow up with the tests and ST checks.
…On Fri, Jan 16, 2026, 03:25 Robin Leroy ***@***.***> wrote:
*eggrobin* left a comment (unicode-org/icu#3839)
<#3839 (comment)>
@markusicu <https://github.com/markusicu> How do I deal with the
transliterator breakages until CLDR fixes its rules? Do I just sit on this
PR until then?
—
Reply to this email directly, view it on GitHub
<#3839 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMH5IKB53DLWWBM6X434HDDBDAVCNFSM6AAAAACRGSRVNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONJZGYYDAOBWGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@macchiati please make sure that the translit rules get fixed. |
|
Agreed; Robin shouldn't be blocked on this. |
|
With a quick regex So that matches all of the ones Robin found; that will be easy to fix on the CLDR side |
|
The CLDR PR and ticket are at unicode-org/cldr#5297 |
|
Thanks for doing that @macchiati. I was busy moving so didn’t have the time to look at this. |
richgillam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
ALLOW_MANY_COMMITS=meow