ICU-23333 Create equivalent build.py scripts for all ant tasks#3912
ICU-23333 Create equivalent build.py scripts for all ant tasks#3912mihnita merged 1 commit intounicode-org:mainfrom
Conversation
36763f0 to
9caccc9
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
A small description on how I "mapped" Ant to Python Ant has I mapped each For dependencies I had the dependent method call the dependencies: <target name="cleanprod" depends="init, setup">becomes: def cleanprod():
_init()
_setup()Also, ant invokes the proper target if I pass it in command line: For Python I am doing something similar "by hand", by parsing the cli. This probably accounts >90% "tricks" in this ant->python conversion. |
echeran
left a comment
There was a problem hiding this comment.
I didn't take a deep look, but I assume it's fine. Left a few comments where it's worth making a change / easy to make a change, even given that this will be cleaned up again once Ant is fully removed soon.
|
All feedback implemented, thank you. |
21c3ed0 to
bdbeeef
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
33c8c05 to
96ed4dc
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
The code is a very close equivalent of the ant scripts, even if that means it's not very idiomatic Python.
Global variables (a few), each ant task becomes a function, task dependencies means that the function calls the dependent functions first.
We might polish later if desired.
Checklist