measunit_extra.cpp: Fix error: 'abs' ambiguous#3916
Open
Dave-Allured wants to merge 1 commit intounicode-org:mainfrom
Open
measunit_extra.cpp: Fix error: 'abs' ambiguous#3916Dave-Allured wants to merge 1 commit intounicode-org:mainfrom
Dave-Allured wants to merge 1 commit intounicode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
measunit_extra.cpp, lines 687-689:
This code is used to check an input string for a non-integer value.
With some older compilers, this generates "error: call to 'abs' is ambiguous".
This PR will avoid the "abs" error by replacing the handcrafted fractional test, with appropriate use of "modf".
I am not experienced with C++. Someone please check this work, thank you.
Downstream issue with complete build log: https://trac.macports.org/ticket/73705
Platform was: macOS 10.14.6 (darwin/18.7.0) arch i386
Compiler was: Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Dialect flag was: -std=gnu++11
TODO: Please read the following on ICU Contributing, and then delete these instructions.
-- Did not read. If this PR is not tolerable, let me know and I will fix.
-- Did not read.
-- Did not file a Jira issue.
Checklist