Compute LunarChinese reference years with new algorithm #7007
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
| (10, true, false) => 1870, | ||
| (10, true, false) => 1984, |
There was a problem hiding this comment.
Observation: I do indeed see a M10L (闰十月) in the year 1984 in the PMO file and it has 29 days
| (9, true, false) => 1832, | ||
| (9, true, false) => 2014, |
There was a problem hiding this comment.
Observation: I see a M09L (闰九月) in the year 2014 in the PMO file and it has 29 days
| (9, false, false) => 1972, | ||
| (9, false, true) => 1972, | ||
| (9, true, false) => 1832, | ||
| (9, true, false) => 2014, |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think in these cases because they were not super far in the past I continued with the backwards-looking algorithm, but the 1900 cutoff seems good.
| (10, false, false) => 1972, | ||
| (10, false, true) => 1972, | ||
| (10, true, false) => 1870, | ||
| (10, true, false) => 1984, |
There was a problem hiding this comment.
3 participants
tc39/proposal-temporal#3152