Refactor env_preferences to host_info #7113
Conversation
zbraniecki
force-pushed
the
host_info
branch
10 times, most recently
from
7b7864e to
84e83fe
Compare
| /// assert_eq!(attrs, "foobar-foobaz-fooqux".parse().unwrap()); | ||
| /// ``` | ||
| #[cfg(feature = "alloc")] | ||
| pub fn extend(&mut self, other: Attributes) { |
There was a problem hiding this comment.
issue: these are new public APIs, we should consider these carefully
There was a problem hiding this comment.
this is reviewed in #7112
|
|
||
| /// An error encountered while retrieving the host information | ||
| #[derive(Debug, Display)] | ||
| pub enum HostInfoError { |
There was a problem hiding this comment.
thought (non blocking for initial landing): We should eventually consider whether we should split this into fine grained errors. Probably not, most of these are general.
There was a problem hiding this comment.
I went back and forth on this and ended up coalescing. The original crate had more types of errors but I couldn't find a persona except of "ICU4X code contributor" who would be affected to the point where different classes of errors make sense.
| use crate::error::HostInfoError; | ||
|
|
||
| #[derive(Hash, Eq, PartialEq, Debug, Clone, Copy)] | ||
| pub enum LocaleCategory { |
There was a problem hiding this comment.
issue: is this actually pub, or just pub(crate)? Should this be under shared/ or something so that backend-specific stuff is distinct from API?
There was a problem hiding this comment.
Many different OSes use some parts of POSIX (Android, Mac, Linux, Vega). I'm open to adjust visibility.
Right now it is private.
There was a problem hiding this comment.
In that case, this should be pub(crate)
And perhaps the file should be under backends/shared/posix.rs
|
I'll need help figuring out how to avoid enabling |
2 participants
Depends on #7112 .
Partially resolves #5869 implementing refactor plus documentation, and fixing #6574 .