Add methods to load LSTM or dictionary data for existing segmenters #7590
+277
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
aethanyc,
makotokato and
sffc
as code owners
Member
|
Or they can just implement a custom DataProvider? If this case is common enough I guess these methods are harmless. |
sffc
approved these changes
Feb 5, 2026
Member
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
We use this builder pattern in DateTimeNames, which is a power-user API, but it seems okay here too.
components/segmenter/src/word.rs
Outdated
| /// ✨ *Enabled with the `compiled_data` and `lstm` Cargo features.* | ||
| #[cfg(feature = "lstm")] | ||
| #[cfg(feature = "compiled_data")] | ||
| pub fn with_lstm_unstable(mut self) -> Self { |
Member
There was a problem hiding this comment.
Observation: _unstable is on the owned type and compiled data is on the Borrowed type.
|
|
||
| /// Loads dictionary data for a [`WordSegmenter`] constructed with | ||
| /// [`WordSegmenter::new_for_non_complex_scripts`]. | ||
| pub fn with_dictionary_unstable<D>(mut self, provider: &D) -> Result<Self, DataError> |
Member
There was a problem hiding this comment.
Question: Should we have the buffer versions, too?
Manishearth
reviewed
Feb 9, 2026
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Defer to Shane, broadly speaking looks fine
robertbastian
force-pushed
the
segmenter
branch
from
2e8dbfd to
fbb64a1
Compare
robertbastian
force-pushed
the
segmenter
branch
from
fbb64a1 to
c20f629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients want to do custom dictinoary/lstm loading, without doing full custom data loading for segmenters. We can extend
Segmenter::new_for_non_complex_scriptswith methodsload_lstmandload_dictionaryso that the non-complex script data can be loaded from a different source, or behind a Cargo feature, without jumping through the hoops of defining a branching data provider or reloading data that has already been loaded.