Add latest-tag value for icu4x-datagen tag arguments #7599
+26
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
a team,
Manishearth and
robertbastian
as code owners
robertbastian
requested changes
Feb 9, 2026
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
Did you test this? There are two issues why I didn't implement this two years ago, neither of which seem to be addressed in this PR:
- The normal GitHub URL is
<repo>/releases/download/{tag}/foo.zip, but thelatestURL is<repo>/releases/latest/download/foo.zip. - CLDR-JSON contains the version in the file name, you can't just use
latest. This points to the fundamental issue I have with this: CLDR-JSON doesn't use the same file name for each release because it's not designed to just swap in data from a different release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7510