-
Notifications
You must be signed in to change notification settings - Fork 262
feat(datetime): Add YearStyle::Always and YearStyle::Never #7606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(datetime): Add YearStyle::Always and YearStyle::Never #7606
Conversation
sffc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always is the same as WithEra and is not needed.
Never would be a useful addition, but it seems like not a good addition to the enum which is named YearStyle, not EraDisplay as the ECMA proposal.
Also please note the "implied" style in the ECMA proposal.
Thanks for the review! After investigating the TC39 proposal-intl-eradisplay, I found: Current proposal status (Stage 2):
Issues with my implementation:
Proposed path forward:
Should I close this PR for now? Should I update issue #6010 with these findings? |
|
We would accept a PR adding something like There is discussion of |
8f4875d to
464c53a
Compare
464c53a to
b196039
Compare
|
@sffc sir i tried to make those suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion (optional): Split this test into tests on each variant, and replace the top-level docs here with a table summarizing the results.
e3a5287 to
5261891
Compare
Co-authored-by: Shane F. Carr <shane@unicode.org>
5261891 to
7a5e317
Compare
Adds YearStyle::Always and YearStyle::Never options as per TC39 intl-eradisplay proposal.
Fixes #6010