added guard for implicit features #7608
Open
+141
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3004
Summary :- the function
check_implicit_featurescollect the paths of allcargo.tomlfiles, which packages are in workspace and which dependencies are optional usingcargo metadata. Then using thetomlcrate it parses thecargo.tomlfiles and checks what features are explicitly defined by the developer and whether any feature referencesdep:<name>for each optionaldep.It detects implicit features when an optional dependency:
[features]dep:<name>anywhere in[features]