Generate binary properties FFI code (#7233) #7613
Open
+1,224
−1,028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Jinja template for properties_sets.rs - Update codegen script for 69 binary properties - Generate properties_sets.rs from template Fixes unicode-org#7233
Jayant-kernel
force-pushed
the
fix-7233-clean-final
branch
from
7dd7a1d to
3733aba
Compare
Jayant-kernel
force-pushed
the
fix-7233-clean-final
branch
from
3733aba to
17e3ba8
Compare
- Add Jinja template for properties_sets.rs - Update codegen script for 69 binary properties - Generate properties_sets.rs from template Fixes unicode-org#7233
Jayant-kernel
force-pushed
the
fix-7233-clean-final
branch
from
17e3ba8 to
c5d0685
Compare
Contributor
Author
|
@Manishearth @sffc ,I've created a clean PR with only the core changes for #7233: Update: I've made the following changes based on CI feedback: ✅ Regenerated Diplomat bindings (now 10 files changed instead of 3) |
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
✅ Regenerated Diplomat bindings (now 10 files changed instead of 3)
None should change.
✅ Fixed template compilation error (changed properties to binary_props in the Jinja template)
Still doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #7233 by using Jinja templates to auto-generate FFI code for 69 binary Unicode properties.
Changes
properties_sets.rs.jinja) for binary propertiesImplementation
Follows the same pattern as PR #7366 (enumerated properties). The template generates three functions for each binary property:
{property}_for_char()- Check property for a single charactercreate_{property}()- Create property set with compiled datacreate_{property}_with_provider()- Create with custom providerTesting
cargo run -p codegensuccessfullyFixes #7233