Skip to content

Implement stateful surpasses() for until() #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manishearth merged 12 commits into from
Mar 13, 2026
Merged

Implement stateful surpasses() for until() #7745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ce13e6a
Implement stateful `surpasses()` to improve year/month `until()` perf…
poulsbo Mar 6, 2026
64b3d14
Clippy insisted on backticks (take 2)
poulsbo Mar 6, 2026
004128c
Cleanup: Add closing backticks in deprecated messages
poulsbo Mar 11, 2026
f7dccb3
Improved stateful surpasses() impl that hews closely to the NonISODat…
poulsbo Mar 10, 2026
2cb4975
Allow dead code for surpasses() method
poulsbo Mar 11, 2026
d3c693f
Update components/calendar/src/calendar_arithmetic.rs
poulsbo Mar 13, 2026
7dc6469
Incorporate feedback from sffc, clarify `SurpassesChecker` API
poulsbo Mar 13, 2026
adbe1ed
Merge branch 'main' into stateful-surpasses
poulsbo Mar 13, 2026
a01d17d
fmt
poulsbo Mar 13, 2026
b146b1b
Merge branch 'main' into stateful-surpasses
poulsbo Mar 13, 2026
f58a9da
changelog
poulsbo Mar 13, 2026
c3b11ee
revert accidental CHANGELOG.md change
poulsbo Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions components/calendar/src/cal/east_asian_traditional.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ impl KoreanTraditional {
/// Use [`Self::new`].
#[cfg(feature = "serde")]
#[doc = icu_provider::gen_buffer_unstable_docs!(BUFFER,Self::new)]
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn try_new_with_buffer_provider(
_provider: &(impl BufferProvider + ?Sized),
) -> Result<Self, DataError> {
Expand All @@ -412,13 +412,13 @@ impl KoreanTraditional {

/// Use [`Self::new`].
#[doc = icu_provider::gen_buffer_unstable_docs!(UNSTABLE, Self::new)]
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn try_new_unstable<D: ?Sized>(_provider: &D) -> Result<Self, DataError> {
Ok(Self::new())
}

/// Use [`Self::new`].
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn new_always_calculating() -> Self {
Self::new()
}
Expand Down Expand Up @@ -550,21 +550,21 @@ impl ChineseTraditional {

#[cfg(feature = "serde")]
#[doc = icu_provider::gen_buffer_unstable_docs!(BUFFER,Self::new)]
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn try_new_with_buffer_provider(
_provider: &(impl BufferProvider + ?Sized),
) -> Result<Self, DataError> {
Ok(Self::new())
}

#[doc = icu_provider::gen_buffer_unstable_docs!(UNSTABLE, Self::new)]
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn try_new_unstable<D: ?Sized>(_provider: &D) -> Result<Self, DataError> {
Ok(Self::new())
}

/// Use [`Self::new()`].
#[deprecated(since = "2.1.0", note = "use `Self::new()")]
#[deprecated(since = "2.1.0", note = "use `Self::new()`")]
pub fn new_always_calculating() -> Self {
Self::new()
}
Expand Down
4 changes: 2 additions & 2 deletions components/calendar/src/cal/hijri.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,15 +1070,15 @@ impl<A: AsCalendar<Calendar = Hijri<R>>, R: Rules> Date<A> {

impl Date<Hijri<UmmAlQura>> {
/// Deprecated
#[deprecated(since = "2.1.0", note = "use `Date::try_new_hijri_with_calendar")]
#[deprecated(since = "2.1.0", note = "use `Date::try_new_hijri_with_calendar`")]
pub fn try_new_ummalqura(year: i32, month: u8, day: u8) -> Result<Self, RangeError> {
Date::try_new_hijri_with_calendar(year, month, day, Hijri::new_umm_al_qura())
}
}

impl<A: AsCalendar<Calendar = Hijri<TabularAlgorithm>>> Date<A> {
/// Deprecated
#[deprecated(since = "2.1.0", note = "use `Date::try_new_hijri_with_calendar")]
#[deprecated(since = "2.1.0", note = "use `Date::try_new_hijri_with_calendar`")]
pub fn try_new_hijri_tabular_with_calendar(
year: i32,
month: u8,
Expand Down
Loading
Loading