Add impl From<u8> for Month with basic docs examples#7776
Open
sffc wants to merge 5 commits intounicode-org:mainfrom
Open
Add impl From<u8> for Month with basic docs examples#7776sffc wants to merge 5 commits intounicode-org:mainfrom
impl From<u8> for Month with basic docs examples#7776sffc wants to merge 5 commits intounicode-org:mainfrom
Conversation
Member
|
I removed the usage of into from #7773 since that PR does more things. This PR can simply use the into impl where it wants to after merging that. |
Manishearth
approved these changes
Mar 13, 2026
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
The From impl probably needs to be removed after a rebase but this lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-written piece of #7773
Changelog
icu_calendar: add
impl From<u8> for Monththat generates normal months