feat: Add currency display options to CurrencyFormatter (#7785)#7789
Open
younies wants to merge 1 commit intounicode-org:mainfrom
Open
feat: Add currency display options to CurrencyFormatter (#7785)#7789younies wants to merge 1 commit intounicode-org:mainfrom
younies wants to merge 1 commit intounicode-org:mainfrom
Conversation
Enhance the CurrencyFormatterOptions struct to include a currency_display field, allowing for different display styles (Symbol, NarrowSymbol, Code, Name). Implement tests for each display style in the format module, ensuring correct formatting for USD in the en-US locale. ## Changelog - Added currency display options to CurrencyFormatter - Implemented tests for various currency display styles
younies
changed the title
Member
Author
sffc
approved these changes
Mar 19, 2026
Member
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
I think we should remove the width option, since it is covered by the currency_display option.
|
|
||
| /// The display style for currencies. | ||
| /// Default is [`CurrencyDisplay::Symbol`]. | ||
| pub currency_display: CurrencyDisplay, |
Member
There was a problem hiding this comment.
As noted in the other PR, options should be optional:
Suggested change
| pub currency_display: CurrencyDisplay, | |
| pub currency_display: Option<CurrencyDisplay>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the CurrencyFormatterOptions struct to include a
currency_displayfield, allowing for different display styles (Symbol, NarrowSymbol, Code, Name).Implement tests for each display style in the format module and adding todo to implement these test cases.
Changelog
icu_experimental/currency: Add options for selecting currency format style
CurrencyDisplayCurrencyFormatterOptions::currency_displayimpl From<CurrencyDisplay> for CurrencyFormatterOptions