Skip to content

Rationalize name-char #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 17, 2025
Merged

Rationalize name-char #1008

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3293cba
Rationalize name-char
macchiati Feb 16, 2025
677878d
Make corresponding changes in syntax.md
macchiati Feb 16, 2025
5ad3a72
Fix long lines
macchiati Feb 16, 2025
f0d9d54
Fix long lines 2
macchiati Feb 16, 2025
39ece5a
Update spec/syntax.md
aphillips Feb 16, 2025
14eb173
Apply suggestions from code review
macchiati Feb 16, 2025
0eb3c22
Review comment re XML
macchiati Feb 16, 2025
70c3c9c
Drop Cs
macchiati Feb 17, 2025
a668429
Remove Cs from exclusions
macchiati Feb 17, 2025
479e41c
Fix reference to XML
macchiati Feb 17, 2025
1bf206a
Put 'omit' on line before
macchiati Feb 17, 2025
8ff73f7
Put omit on previous line
macchiati Feb 17, 2025
074346a
Drop XML reference
macchiati Feb 17, 2025
bffc098
Apply suggestions from code review
macchiati Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions spec/syntax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,11 +786,9 @@ has been applied to both.
> implementations can often substitute checking for actually applying normalization
> to _name_ values.

Valid content for _names_ is based on <cite>Namespaces in XML 1.0</cite>'s
[NCName](https://www.w3.org/TR/xml-names/#NT-NCName).
This is different from XML's [Name](https://www.w3.org/TR/xml/#NT-Name)
in that it MUST NOT contain a U+003A COLON `:`.
Otherwise, the set of characters allowed in a _name_ is large.
The _names_ are [immutable identifiers](https://www.unicode.org/reports/tr31/#Immutable_Identifier_Syntax).
They are similar to <cite>Namespaces in XML 1.0</cite>'s [NCName](https://www.w3.org/TR/xml-names/#NT-NCName),
but have been updated to be more consistent.
Copy link
Collaborator

@eemeli eemeli Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how far we've departed from that spec, this note seems only relevant within the history of the spec, and not with where we're ending up with this PR. I'd prefer dropping it, and moving the preceding sentence (if keeping) above the preceding note.

Copy link
Member Author

@macchiati macchiati Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.


> [!NOTE]
> _External variables_ can be passed in that are not valid _names_.
Expand Down