Skip to content

Require digit size to support values 0-99 #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Require digit size to support values 0-99 #1013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f02967
Require digit size to support values 0-99
eemeli Feb 17, 2025
be093d9
One less option
eemeli Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/functions/number.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,8 @@ such as the number of fraction, integer, or significant digits.
A "digit size option" is an _option_ value that the _function_ interprets
as a small integer value greater than or equal to zero.
Implementations MAY define an upper limit on the _resolved value_
of a digit size option option consistent with that implementation's practical limits.
of a digit size option consistent with that implementation's practical limits,
as long as all integer values from 0 to 99 (inclusive) are supported.
Copy link
Member

@macchiati macchiati Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99 is way beyond the significant digits supported by an IEEE754 double. If we are going to require minimal values, it shouldn't be more than needed with double, which means it may vary according to the option.

Copy link
Member

@aphillips aphillips Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this isn't the right fix. I think what you're trying to say is maybe:

Suggested change
as long as all integer values from 0 to 99 (inclusive) are supported.
of a digit size option consistent with that implementation's practical limits.
Implementations that do so MUST emit an _Unsupported Operation_ error.
The literal values for integers from 0 to 99 (inclusive) MUST NOT produce
a _Bad Option_ error.

(Note that your text has "option option")

Copy link
Collaborator Author

@eemeli eemeli Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent here was to clarify the general case, but arguably that does complicate matters; the current language allows more clearly for an implementation to define a different upper bound for each digit size option.

The "option option" text is currently in the spec; we should fix that separately if discarding this change.


In most cases, the value of a digit size option will be a string that
encodes the value as a non-negative integer.
Expand Down