Skip to content

Clarify option resolution regarding fallback option values #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Clarify option resolution regarding fallback option values #1054

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b82235
Make option resolution return something if `rv` is a fallback value
aphillips Mar 6, 2025
78ecb08
Add note and rephrase slightly
aphillips Mar 7, 2025
1c885e6
Update spec/formatting.md
aphillips Mar 9, 2025
ea3f0ba
Update spec/formatting.md
aphillips Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion spec/formatting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,13 +395,17 @@ For each _option_:
1. Let `id` be the string value of the _identifier_ of the _option_.
1. Let `rv` be the _resolved value_ of the _option value_.
1. If `rv` is a _fallback value_:
1. If supported, emit a _Bad Option_ error.
1. Emit a _Bad Option_ error, if supported.
1. Else:
1. If the _option value_ consists of a _literal_:
1. Mark `rv` as a _literal_ _option value_.
1. Set `res[id]` to be `rv`.
1. Return `res`.

> [!NOTE]
> If the _resolved value_ of an _option value_ is a _fallback value_,
> the _option_ is intentionally omitted from the mapping of resolved options.

The result of _option resolution_ MUST be a (possibly empty) mapping
of string identifiers to values;
that is, errors MAY be emitted, but such errors MUST NOT be fatal.
Expand Down