Skip to content

Fix contradiction in markup resolution #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2025
Merged

Fix contradiction in markup resolution #1084

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ffd1ea
Fix contradiction in markup resolution
catamorphism Jun 28, 2025
9987937
Revise change to mention option resolution being non-fatal
catamorphism Jul 1, 2025
cf95ccf
Move 'Option Resolution' section
catamorphism Jul 14, 2025
03e851e
Update spec/formatting.md
catamorphism Jul 16, 2025
bb7e547
Rephrase parenthetical in 'markup resolution' section
catamorphism Jul 16, 2025
e39f203
Reorder sections
catamorphism Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spec/formatting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,9 @@ supported by the implementation, process them as specified.
Such `u:` options MAY be removed from the resolved mapping of _options_.

The resolution of _markup_ MUST always succeed.
As with _option resolution_ for _expressions_,
Copy link
Member

@aphillips aphillips Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be confusing. The first normative statement (resolution of markup must always succeed) is a separate requirement. So I'd go:

Suggested change
As with _option resolution_ for _expressions_,
In addition, as with _option resolution_ in _expressions_,

_option resolution_ for _markup_ MAY emit errors,
but such errors MUST NOT be fatal.

#### Fallback Resolution

Expand Down