Skip to content

Add :string as formatter and selector #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2024
Merged

Add :string as formatter and selector #594

merged 2 commits into from
Jan 15, 2024

Conversation

@eemeli
Copy link
Collaborator

@eemeli eemeli commented Jan 15, 2024

This implements the proposed design, and marks the design as approved.

@eemeli eemeli added requirements Issues related with MF requirements list design Design document or issues related to design functions Issue pertains to the default function set Agenda+ Requested for upcoming teleconference LDML45 labels Jan 15, 2024
@eemeli eemeli linked an issue Jan 15, 2024 that may be closed by this pull request
How to name string-match selector: :string, :select, :equals or something else? #433
Closed
aphillips
aphillips requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the spelling error

@eemeli @aphillips
Apply suggestions from code review
fb047bf 
Co-authored-by: Addison Phillips <[email protected]>
@eemeli eemeli requested a review from aphillips January 15, 2024 15:12
@aphillips aphillips merged commit 8a788c4 into main Jan 15, 2024
@aphillips aphillips deleted the add-string branch January 15, 2024 18:26
@eemeli eemeli added this to the LDML 45 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphillips aphillips aphillips approved these changes

Assignees

No one assigned

Labels

Agenda+ Requested for upcoming teleconference design Design document or issues related to design functions Issue pertains to the default function set requirements Issues related with MF requirements list

Projects

None yet

Milestone

LDML 45

Development

Successfully merging this pull request may close these issues.

How to name string-match selector: :string, :select, :equals or something else?

3 participants

@eemeli @aphillips