-
-
Notifications
You must be signed in to change notification settings - Fork 35
Prepare front-door for Tech Preview #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b48c4b3
Prepare front-door for Tech Preview
aphillips 1758cd7
Update README.md
aphillips e205df4
address comments
aphillips d308f32
Update README.md
aphillips b688e0c
Update README.md
aphillips be799ef
Update README.md
aphillips c720a6a
Update README.md
aphillips a0c258b
Remove distracting link
aphillips 8136c3f
Add sentence on data model
eemeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per recent discussions, I think we also care about feedback on the resolved value details (#678), and I personally would also like feedback on the desirability of syntax divergence between simple and complex messages (which is more general than #610 in its current form, cf. #610 (comment) and its outbound link tree). I guess the latter might be #512?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. The list here consists strictly of items tagged with "seek feedback" label. I agree with most of your observations and will add some details shortly.
I think these are details of the syntax? Wouldn't feedback about the syntax in general work better? How intuitive (or unintuitive) it is to use, whether simple-vs-complex is easy to grok, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we should have specific prompts to get specific feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always happy to get suggestions 😸