-
-
Notifications
You must be signed in to change notification settings - Fork 35
Create ack section #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ack section #737
Conversation
Co-authored-by: Tim Chevalier <[email protected]>
| ## Acknowledgements | ||
|
|
||
| Special thanks to the following people for their contributions to making MessageFormat v2. | ||
| The following people contributed to our github repo and are listed in order by contribution size: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may have a bit of a skew caused by the fact that git commits are not the only way people have participated. Is there maybe a way to also count the number of issue/pr comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. Note that this also counts issues.
I could alphabetize by family name. The idea of organizing by what github gives us it that is provides some weighting for "participation" without trying to reconstruct specific contributions. I could also look back at meeting minutes to see if we're missing someone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You make a good point: once we decide to use something other than what GitHub gives us by default, we're in the business of making it as close to the true representation of participation as possible, and that's very hard to do right.
I think it's OK to merge this as-is.
|
Just a note: we typically let people specify a native script version of their names in parentheses. If anyone wants that, I suggest a follow-on PR. |
Create the acknowledgements section. Addresses #711. See that issue for how this was created (although it is self-describing).
Additional names are welcome! Specific acknowledgements for specific deeds are also welcome (as mentioned in the 2024-03-18 call). No omission is intentional. Don't feel shy about putting your name on our work.