A few proposed tweaks to syntax.md. #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assumes that PR unicode-org#731 is applied. In detail: * Since the reserved keywords start with a `.`, we need to talk about the keyword `.match`, not `match`. * Saying that "A _reserved annotation_ starts with a reserved character" and "A _reserved annotation_ MAY be empty" is a contradiction. Therefore, we need to distinguish a _reserved annotation_ from a _reserved body_. This distinction is also useful because the _reserved body_ occurs in two other places as well. * The statement that a _reserved body_ contains "arbitrary text" is not true, since we have now decided that (unless empty) it must start and end with a non-whitespace character. * A nonterminal `reserved-start` does not exist. What is meant is `reserved-annotation-start`. * The statement "Implementations MUST NOT remove or alter the contents of a _reserved annotation_." needs to be constrained, because now implementations are SUPPOSED to trim whitespace around the _reserved body_.
aphillips
requested changes
Mar 25, 2024
aphillips
added
syntax
Co-authored-by: Addison Phillips <[email protected]>
aphillips
reviewed
Mar 25, 2024
bhaible
force-pushed
the
tweaks-for-syntax-md
branch
from
adf8a54 to
0e3ffdb
Compare
mihnita
approved these changes
Mar 25, 2024
aphillips
approved these changes
Mar 25, 2024
|
@eemeli asked to review this before we merge it during the 2024-03-25 call. |
eemeli
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that PR #731 is applied.
In detail:
Since the reserved keywords start with a
., we need to talk about the keyword.match, notmatch.Saying that "A reserved annotation starts with a reserved character" and "A reserved annotation MAY be empty" is a contradiction. Therefore, we need to distinguish a reserved annotation from a reserved body. This distinction is also useful because the reserved body occurs in two other places as well.
The statement that a reserved body contains "arbitrary text" is not true, since we have now decided that (unless empty) it must start and end with a non-whitespace character.
A nonterminal
reserved-startdoes not exist. What is meant isreserved-annotation-start.The statement "Implementations MUST NOT remove or alter the contents of a reserved annotation." needs to be constrained, because now implementations are SUPPOSED to trim whitespace around the reserved body.