Skip to content

Conversation

@catamorphism
Copy link
Collaborator

Per discussion on #759 , this PR removes expected output for :date, :time, and :datetime, except for error cases (since fallback handling is part of the spec).

Also added a note in the README to explain that.

I didn't remove the expected output for :number/:integer test cases, since that seems less likely to vary? But perhaps that should be done as well.

The expected output is implementation-specific.
Also added a note in the README to that effect.
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a Prettier formatting run of the changed files, to prevent them being reformatted later.

Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might be nice to convert the exp that were removed to comments, though.

@aphillips aphillips added fast-track Editorial change permitted to use fast-track merge rules formatting Issue pertains to the formatting section of the spec LDML45 test-suite Issue pertains to tests labels Apr 6, 2024
@macchiati
Copy link
Member

macchiati commented Apr 6, 2024 via email

@aphillips
Copy link
Member

One thought. Could retain the data, and document in the header that
conformance doesn't require exactly the same value. Non-cldr
implementations can test simply that a value is produced.

CLDR ones too. Date/time formats evolve over time; a good set of tests probably encompasses many locales and the full option set.

There should probably be some text about testing that says, effectively, "insert your platform integration tests here"

@aphillips aphillips merged commit fdee563 into unicode-org:main Apr 8, 2024
@macchiati
Copy link
Member

macchiati commented Apr 8, 2024 via email

@eemeli eemeli added this to the LDML 45 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Editorial change permitted to use fast-track merge rules formatting Issue pertains to the formatting section of the spec test-suite Issue pertains to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants