Skip to content

Conversation

@aphillips
Copy link
Member

This wasn't done in time for the LDML45 release, but capturing it publicly for later implementation. Can be added to the tr35-messageformat.html file.

This wasn't done in time for the LDML45 release, but capturing it publicly for later implementation. Can be added to the `tr35-messageformat.html` file.
@aphillips aphillips added documentation Improvements or additions to documentation editorial Issue is non-normative specification Issue affects the specification LDML46 labels Apr 10, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I can do this with a setting on the linkifier already being used

@srl295
Copy link
Member

srl295 commented Apr 10, 2024

LGTM. I think I can do this with a setting on the linkifier already being used

https://github.com/unicode-org/cldr/blob/534a9278894440befa214917c6a413475d237632/tools/scripts/tr-archive/archive.js#L145

I think adding 'dfn' to that should do what it seems like you're trying to do.
since you are setup with the tools locally you could PR that into the repo if it works locally

@srl295
Copy link
Member

srl295 commented Apr 10, 2024

see unicode-org/cldr#3629

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs formatting by Prettier. With markdown I could be persuaded that sticking to it was too much of a hassle, but this code... is another matter.

Also, while you do get extra bonus brownie points for using let and const and var, you really shouldn't.

I'll look at this in more details once it's formatted.

bidi isolation _strategies_ 😉 

Also added a bit of debugging gorp
@aphillips
Copy link
Member Author

@srl295 Adding 'dfn' to the archive.js does work to create anchors. I will PR that into the repo anon.

Turning em tags into links if-and-only-if there is an anchor would still need to be added.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work? It's a bit messy and stylistically questionable, but it's probably fine. Presuming that there's calling code somewhere.

Thanks to @eemeli
Eliminates globals and does all the work in `linkify`
@aphillips aphillips merged commit a31b053 into main Apr 15, 2024
@aphillips aphillips deleted the aphillips-linkify branch April 15, 2024 16:38
@eemeli eemeli added this to the LDML 46 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation editorial Issue is non-normative specification Issue affects the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants