-
-
Notifications
You must be signed in to change notification settings - Fork 35
Linkify the specification #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This wasn't done in time for the LDML45 release, but capturing it publicly for later implementation. Can be added to the `tr35-messageformat.html` file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think I can do this with a setting on the linkifier already being used
I think adding 'dfn' to that should do what it seems like you're trying to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs formatting by Prettier. With markdown I could be persuaded that sticking to it was too much of a hassle, but this code... is another matter.
Also, while you do get extra bonus brownie points for using let and const and var, you really shouldn't.
I'll look at this in more details once it's formatted.
bidi isolation _strategies_ 😉 Also added a bit of debugging gorp
|
@srl295 Adding 'dfn' to the archive.js does work to create anchors. I will PR that into the repo anon. Turning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work? It's a bit messy and stylistically questionable, but it's probably fine. Presuming that there's calling code somewhere.
Eliminates globals and does all the work in `linkify`
This wasn't done in time for the LDML45 release, but capturing it publicly for later implementation. Can be added to the
tr35-messageformat.htmlfile.