-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add design doc for error handling #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1c5d62e
Add design doc for error handling
echeran d212fb7
Apply suggestions from code review
echeran 2fd70e4
Update exploration/error-handling.md
echeran 0b0e90c
Update text of proposed alternative to simplify and add incremental c…
echeran d55e194
Reword to unambiguously convey correct summary
echeran 25f9fcd
Add example of coding guidelines
echeran ade8735
Add paragraph indicating word choice of "signal" vs. "emit" & "return"
echeran be5f9a0
Add additional alternative still maintaining both MUST clauses
echeran 6c9fff0
Update exploration/error-handling.md
echeran 5f7c317
Apply suggestions from code review
echeran dd20f33
Apply suggestions from code review
echeran aee2fb6
Add ballot options from #830, designate selected design as such
echeran 1051cee
Add meeting notes and ballot issues
echeran 084a1de
Apply suggestions from code review
echeran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.