- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 35
 
Fix fallback value definition and use #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            15 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      b10b045
              
                Fix references to fallback values
              
              
                eemeli 684a006
              
                Apply suggestions from code review
              
              
                eemeli ed99d8d
              
                Apply suggestions from code review
              
              
                eemeli eaa6171
              
                Apply suggestions from code review
              
              
                eemeli 65677bb
              
                Typo fix
              
              
                eemeli e183a4d
              
                Note that operand options are not handled by Option Resolution
              
              
                eemeli 0b0b518
              
                Apply suggestions from code review
              
              
                eemeli f95eda7
              
                Fix typo
              
              
                eemeli 38c8542
              
                Merge branch 'main' into fix-fallback-also
              
              
                aphillips 83d8011
              
                Use last rather than earliest operand for fallback value
              
              
                eemeli 309f7a4
              
                Merge branch 'main' into fix-fallback-also
              
              
                eemeli 65e902a
              
                Use last name also during fallback in variable resolution
              
              
                eemeli a63c6a2
              
                Add tests for fallback formatting
              
              
                eemeli 9d56bee
              
                Tighten up language about fallback values, their string representatio…
              
              
                eemeli 6f3948d
              
                Add "if supported" qualifier to emitting Bad Option error during opti…
              
              
                eemeli File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/unicode-org/message-format-wg/main/test/schemas/v0/tests.schema.json", | ||
| "scenario": "Fallback", | ||
| "description": "Test cases for fallback behaviour.", | ||
| "defaultTestProperties": { | ||
| "bidiIsolation": "none", | ||
| "locale": "en-US", | ||
| "expErrors": true | ||
| }, | ||
| "tests": [ | ||
| { | ||
| "description": "function with unquoted literal operand", | ||
| "src": "{42 :test:function fails=format}", | ||
| "exp": "{|42|}" | ||
| }, | ||
| { | ||
| "description": "function with quoted literal operand", | ||
| "src": "{|C:\\\\| :test:function fails=format}", | ||
| "exp": "{|C:\\\\|}" | ||
| }, | ||
| { | ||
| "description": "unannotated implicit input variable", | ||
| "src": "{$var}", | ||
| "exp": "{$var}" | ||
| }, | ||
| { | ||
| "description": "annotated implicit input variable", | ||
| "src": "{$var :number}", | ||
| "exp": "{$var}" | ||
| }, | ||
| { | ||
| "description": "local variable with unknown function in declaration", | ||
| "src": ".local $var = {|val| :test:undefined} {{{$var}}}", | ||
| "exp": "{$var}" | ||
| }, | ||
| { | ||
| "description": "function with local variable operand with unknown function in declaration", | ||
| "src": ".local $var = {|val| :test:undefined} {{{$var :test:function}}}", | ||
| "exp": "{$var}" | ||
| }, | ||
| { | ||
| "description": "local variable with unknown function in placeholder", | ||
| "src": ".local $var = {|val|} {{{$var :test:undefined}}}", | ||
| "exp": "{$var}" | ||
| }, | ||
| { | ||
| "description": "function with no operand", | ||
| "src": "{:test:undefined}", | ||
| "exp": "{:test:undefined}" | ||
| } | ||
| ] | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.