-
-
Notifications
You must be signed in to change notification settings - Fork 35
Implement :currency function in the default registry
#915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
9845582
81ded2a
ebd8678
cec72a3
447bf1c
c6ba0fd
2217387
241d442
3f855fc
5b81768
d0c37eb
bbc7091
8a9b63f
b27e95f
236b781
f3b2872
e1a1f45
ef98226
a80c0e2
c78745d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -171,37 +171,6 @@ with _options_ on the _expression_ taking priority over any option values of the | |
| > would be formatted with the resolved options | ||
| > `{ notation: 'scientific', minimumFractionDigits: '1' }`. | ||
|
|
||
| > [!NOTE] | ||
| > The following options and option values are being developed during the Technical Preview | ||
| > period. | ||
|
|
||
| The following values for the option `style` are _not_ part of the default registry. | ||
| Implementations SHOULD avoid creating options that conflict with these, but | ||
| are encouraged to track development of these options during Tech Preview: | ||
| - `currency` | ||
| - `unit` | ||
|
|
||
| The following options are _not_ part of the default registry. | ||
| Implementations SHOULD avoid creating options that conflict with these, but | ||
| are encouraged to track development of these options during Tech Preview: | ||
| - `currency` | ||
| - valid [Unicode Currency Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeCurrencyIdentifier) | ||
| (no default) | ||
| - `currencyDisplay` | ||
| - `symbol` (default) | ||
| - `narrowSymbol` | ||
| - `code` | ||
| - `name` | ||
| - `currencySign` | ||
| - `accounting` | ||
| - `standard` (default) | ||
| - `unit` | ||
| - (anything not empty) | ||
| - `unitDisplay` | ||
| - `long` | ||
| - `short` (default) | ||
| - `narrow` | ||
|
|
||
| ##### Default Value of `select` Option | ||
|
|
||
| The value `plural` is the default for the option `select` | ||
|
|
@@ -308,37 +277,6 @@ Option values with the following names are however discarded if included in the | |
| - `maximumFractionDigits` | ||
| - `minimumSignificantDigits` | ||
|
|
||
| > [!NOTE] | ||
| > The following options and option values are being developed during the Technical Preview | ||
| > period. | ||
|
|
||
| The following values for the option `style` are _not_ part of the default registry. | ||
| Implementations SHOULD avoid creating options that conflict with these, but | ||
| are encouraged to track development of these options during Tech Preview: | ||
| - `currency` | ||
| - `unit` | ||
|
|
||
| The following options are _not_ part of the default registry. | ||
| Implementations SHOULD avoid creating options that conflict with these, but | ||
| are encouraged to track development of these options during Tech Preview: | ||
| - `currency` | ||
| - valid [Unicode Currency Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeCurrencyIdentifier) | ||
| (no default) | ||
| - `currencyDisplay` | ||
| - `symbol` (default) | ||
| - `narrowSymbol` | ||
| - `code` | ||
| - `name` | ||
| - `currencySign` | ||
| - `accounting` | ||
| - `standard` (default) | ||
| - `unit` | ||
| - (anything not empty) | ||
| - `unitDisplay` | ||
| - `long` | ||
| - `short` (default) | ||
| - `narrow` | ||
|
|
||
| ##### Default Value of `select` Option | ||
|
|
||
| The value `plural` is the default for the option `select` | ||
|
|
@@ -384,6 +322,136 @@ its _resolved value_ contains the implementation-defined integer value | |
| of the _operand_ of the annotated _expression_, | ||
| together with the resolved options' values. | ||
|
|
||
| ### The `:currency` function | ||
|
|
||
| The function `:currency` is an OPTIONAL selector and formatter for currency values, | ||
| which are a specialized form of numeric selection and formatting. | ||
|
|
||
| #### Operands | ||
|
|
||
| The _operand_ of the `:currency` function can be one of any number of | ||
| implementation-defined types, | ||
| each of which contains a numerical `value` and a `currency`; | ||
| or it can be a [Number Operand](#number-operands), as long as the option | ||
| `currency` is provided. | ||
| The option `currency` MUST NOT be used to override the currency of an implementation-defined type. | ||
| Using this option in such a case results in a _Bad Option_ error. | ||
|
|
||
| The value of the _operand_'s `currency` MUST be either a string containing a | ||
| valid [Unicode Currency Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeCurrencyIdentifier) | ||
| or an implementation-defined currency type. | ||
|
|
||
| A [Number Operand](#number-operands) without a `currency` _option_ results in a _Bad Operand_ error. | ||
|
|
||
| > [!NOTE] | ||
| > For example, in ICU4J, the type `com.ibm.icu.util.CurrencyAmount` can be used | ||
| > to set the amount and currency. | ||
|
|
||
| > [!NOTE] | ||
| > For runtime environments that do not provide a ready-made data structure, | ||
| > class, or type for currency values, the implementation ought to provide | ||
| > a data structure, convenience function, or documentation on how to encode | ||
| > the value and currency code for formatting. | ||
| > For example, such an implementation might define a "currency operand" | ||
| > to include a key-value structure with specific keys to be the | ||
| > local currency operand, which might look like the following: | ||
| > ```json | ||
| > "operandName": { | ||
| > "value": 123.45, | ||
| > "currency": "EUR" | ||
| > } | ||
| > ``` | ||
|
|
||
| #### Options | ||
|
|
||
| Some options do not have default values defined in this specification. | ||
| The defaults for these options are implementation-dependent. | ||
| In general, the default values for such options depend on the locale, | ||
| the currency, | ||
| the value of other options, or all of these. | ||
|
|
||
| Fraction digits for currency values behave differently than for other numeric formatters. | ||
| The number of fraction digits displayed is usually set by the currency used. | ||
| For example, USD uses 2 fraction digits, while JPY uses none. | ||
| Setting `fractionDigits` to `none` makes the display and selection work similar to `:integer`. | ||
aphillips marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Setting some other number of `fractionDigits` allows greater precision display | ||
| (such as when performing currency conversions or other specialized operations) | ||
|
|
||
| > [!NOTE] | ||
| > Except where noted otherwise, the names of _options_ and their _values_ were derived from the | ||
| > [options](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#options) | ||
| > in JavaScript's `Intl.NumberFormat`. | ||
|
|
||
| The following options and their values are required to be available on the function `:currency`: | ||
| - `select` | ||
| - `plural` (default) | ||
| - `ordinal` | ||
| - `exact` | ||
| - `currency` | ||
| - valid [Unicode Currency Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeCurrencyIdentifier) | ||
| (no default) | ||
aphillips marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - `compactDisplay` (this option only has meaning when combined with the option `notation=compact`) | ||
| - `short` (default) | ||
| - `long` | ||
| - `notation` | ||
| - `standard` (default) | ||
| - `compact` | ||
| - `numberingSystem` | ||
| - valid [Unicode Number System Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeNumberSystemIdentifier) | ||
| (default is locale-specific) | ||
| - `currencySign` | ||
| - `accounting` | ||
| - `standard` (default) | ||
| - `currencyDisplay` (this option's values are derived from those in ICU NumberFormatter) | ||
| - `auto` (default) | ||
| - `narrow` | ||
aphillips marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - `short` | ||
| - `iso` | ||
| - `full` | ||
| - `formal` | ||
| - `variant` | ||
eemeli marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - `useGrouping` | ||
| - `auto` (default) | ||
| - `always` | ||
| - `never` | ||
| - `min2` | ||
| - `minimumIntegerDigits` | ||
| - ([digit size option](#digit-size-options), default: `1`) | ||
| - `fractionDigits` (unlike number/integer formats, the fraction digits for currency formatting are fixed) | ||
| - `auto` (default) (the number of digits used by the currency) | ||
| - `none` | ||
| - ([digit size option](#digit-size-options)) | ||
| - `minimumSignificantDigits` | ||
| - ([digit size option](#digit-size-options)) | ||
| - `maximumSignificantDigits` | ||
| - ([digit size option](#digit-size-options)) | ||
|
|
||
| If the _operand_ of the _expression_ is an implementation-defined type, | ||
| such as the _resolved value_ of an _expression_ with a `:currency` _annotation_, | ||
| it can include option values. | ||
| These are included in the resolved option values of the _expression_, | ||
| with _options_ on the _expression_ taking priority over any option values of the _operand_. | ||
|
|
||
| > For example, the _placeholder_ in this _message_: | ||
| > ``` | ||
| > .input {$n :currency currency=USD fractionDigits=none} | ||
| > {{{$n :currency currencySign=accounting}}} | ||
| > ``` | ||
| > would be formatted with the resolved options | ||
| > `{ currencySign: 'accounting', fractionDigits: 'none', currency: 'USD' }`. | ||
|
|
||
| #### Selection | ||
|
|
||
| The _function_ `:currency` performs selection as described in [Number Selection](#number-selection) below. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While considering #933, I realised that plural selection on currency values depends on being able to introspect the fraction digits which are by default locale-dependent. The ICU FormattedNumber might do that automatically, but in other APIs the operation can get a bit trickier. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not locale-dependent. It's currency dependent. This is why fraction digits are different in this function! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
|
|
||
| #### Composition | ||
|
|
||
| When an _operand_ or an _option_ value uses a _variable_ annotated, | ||
| directly or indirectly, by a `:currency` _annotation_, | ||
| its _resolved value_ contains an implementation-defined currency value | ||
| of the _operand_ of the annotated _expression_, | ||
| together with the resolved options' values. | ||
|
|
||
| ### Number Operands | ||
|
|
||
| The _operand_ of a number function is either an implementation-defined type or | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.