-
-
Notifications
You must be signed in to change notification settings - Fork 35
Implement :unit as Proposed RECOMMENDED in the registry
#922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f05d0ba
Implement `:unit` as _OPTIONAL_ in the registry
aphillips 9a5b46a
Update registry.md
aphillips 4a623f9
Remove stray mentions of "currency"
aphillips aaba292
Apply suggestions from code review
aphillips 8786990
Better specify conversion conditions
aphillips b5ef049
Address per-unit comments
aphillips 59ae657
Update spec/registry.md
aphillips 8d83a8f
Changes from 2024-11-04 teleconference
aphillips a76eedc
Make `usage` optional
aphillips d0eb3e3
Add rounding to `:unit`
aphillips 57582ee
Make consistent with other functions
aphillips 0ce878b
Merge branch 'main' into aphillips-unit-format
aphillips 8fe64c9
Linkify some terms; add `Unsupported Operation` for one error
aphillips 0c7beb2
Make section title consistent with other sections
aphillips b90a720
Address comments
aphillips 13e33f0
Address comments
aphillips b5cf412
Address comments, remove unit conversion
aphillips 94c0dec
Move link to unit conversion to correct option
aphillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.